SystemTime::duration_since and UNIX_EPOCH#110
Open
ryan-surname-p wants to merge 3 commits intobytecodealliance:mainfrom
Open
SystemTime::duration_since and UNIX_EPOCH#110ryan-surname-p wants to merge 3 commits intobytecodealliance:mainfrom
ryan-surname-p wants to merge 3 commits intobytecodealliance:mainfrom
Conversation
Author
|
FWIW it builds/tests fine on MacOs after updating llvm clang --version |
Contributor
|
Rather than building out more duplication of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My primary goal here is to make it easy for me to calculate UNIX_EPOCH.
Technically the easiest way to do this would be to extract it from SystemTime's internal DateTime structure; that was my initial approach.
I opted instead to give SystemTime a similar look and feel to the standard library though I did take a bit of a shortcut with SystemTimeError(I'm not actually sure what would happen on overflow).